json-schema-to-typescript icon indicating copy to clipboard operation
json-schema-to-typescript copied to clipboard
verified publisher icon bcherny

Escaping

Open brettz9 opened this issue 3 months ago • 0 comments

  • fix: escape block comment by backslash instead of space; fixes #171
  • chore: update ava and lock file (avoid engines error)

The reason I updated the lock file was for some vulnerabilities fixed by npm audit fix.

The reason I updated ava was because its engines were not supporting Node 22 which I was using.

I added a snapshots script to package.json to update snapshots since this was not a transparent process and required for fixing changed test expectations.

The reason I changed the replacement from * / to *\/ rather than making a normalizer rule per this suggestion is because I think the default behavior should be to work as intended in TypeScript; namely, with the proper escaping, TypeScript will interpret the sequence as the termination of a comment block.

If you go to this snippet and hover the mouse over the function a () {} block, you can see the comment is well-formed.

brettz9 avatar Sep 22 '25 08:09 brettz9