json-schema-to-typescript icon indicating copy to clipboard operation
json-schema-to-typescript copied to clipboard

Add /* prettier-ignore */ to the default banner

Open kalitine opened this issue 6 years ago • 2 comments

By analogy with #195 Pull Request

kalitine avatar Mar 26 '19 17:03 kalitine

Looks good to me! Since most Node.js files are written in JavaScript I would (and have locally) add a eslint disable flag as well.

/* eslint-disable */

krokofant avatar Apr 05 '19 19:04 krokofant

@bcherny Yes, but as I see it there are three options:

  1. Use the formatting rules from the consumers prettier config (where they can also specify ignores)
  2. Ignore all formatting all together
  3. Apply the banners after all other formatting is done

I like the third option so this tool can have decent defaults but exclude it from formatting and style checks on the consumer end.

krokofant avatar Apr 13 '19 23:04 krokofant