Boris Cherny

Results 252 comments of Boris Cherny

+1 same here - example: http://ngmodules.org/modules/format-as-currency

I've just updated all the dependencies to latest. Mind rebasing? Then tests should pass.

+1 There also seems to be a bunch of type errors. To repro, create a new directory, `npm init`, then `npm install json-schema-ref-parser`.

PRs are welcome! You might want to start by looking at the$validators array.

Same here, on OSX. The issue seems to be with Chokidar. Watching ~100 files, if i leave the watcher open for a day the issue tends to happen. Restarting my...

+1 this would enable the currency use case. ie. ``` js $12,356,789.01 $123,567.00 $123.00 ```

Thanks @mohsen1! To get constructors to work, mixin() would have to synthesize a linear prototype chain. I feel sort of meh about doing that, because it means (1) constructing mixed...

> The unfortunate problem is that you can end up writing accidentally wrong code if we omit the global declarations (because you might accidentally redeclare global variables) @DanielRosenwasser AFAIK TS...

Sure @lucashenning, PRs are certainly welcome! I’m excited to hear you’re enjoying this package.