node-smb2 icon indicating copy to clipboard operation
node-smb2 copied to clipboard

CreateReadStream and CreateWriteStream

Open fridjon opened this issue 6 years ago • 2 comments

Are there any plans for implementing createReadStream and createWriteStream (they would be helpful when dealing with large files)? If welcomed I could work on a pull request for this.

I noticed that there is an old closed issue #9 opened in 2015 which resulted in a fork of this project to Node-SMB / marsaud-smb2. Are these projects likely to merge?

fridjon avatar Jan 07 '19 20:01 fridjon

Hi @fridjon,

There is no plan to develop these 2 features in a near future on my side.

That being said these functions are indeed very useful, if you want to own the development of these functions, PR are welcomed and likely to be merged.

Regarding the case the PR #9 the project was forked and was not mergable since the fork was too far away from the original source code. You could still use some of the base work done from marsaud and open a new pull request.

Thanks in advance for the contribution

bchelli avatar Jan 08 '19 22:01 bchelli

createReadStream and createWriteStream are mentioned in the docs: are they supported? Maybe this issue could be closed then?

warpdesign avatar Apr 17 '24 02:04 warpdesign