bcgov
Pull from rocker?
Should we use the dockerfiles from rocker? Eg. shiny or at the very least r-base. Perhaps even better we should use a versioned base from rocker/r-ver for which it looks like they recently added shiny support.
The only thing I would say is .. if it's not broken why fix it? Or, instead of changing this repo, make new one.
Chris
On Fri, May 5, 2017 at 9:29 AM Andy Teucher [email protected] wrote:
Should we use the dockerfiles from rocker? Eg. shiny https://hub.docker.com/r/rocker/shiny/ or at the very least r-base https://hub.docker.com/r/rocker/r-base/. Perhaps even better we should use a versioned base from rocker/r-ver https://hub.docker.com/r/rocker/r-ver/ for which it looks like they recently added shiny support https://github.com/rocker-org/rocker-versioned/tree/master/rstudio.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bcgov/simple-R-shiny/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDITXpXy33vh6ck4N9WVoIkbqQ_4cks5r205dgaJpZM4NSI9j .
Well it's a little bit broken ;) When the latest stable R version changes (as it recently did to 3.4) we have to change the version in the Dockerfile... if we pulled from r-base it would always be up to date. Using a versioned base Dockerfile would make it even more stable, as it will always pull a specific version of R as well as dependent R packages... though we could also expect people to keep their apps up date!
Rocker essentially became a standard in using R with Docker and I think it makes sense to update the repo to reflect this. It would also drastically reduce the time to build the image.
Thanks @sasha-ruby - I'm afraid this repo is a bit out of date. The repo here: https://github.com/bcgov/land-designations-shinyapp has an implementation that has worked well for us and uses the rocker r-base image. I haven't been able to get around to updating this one.
@sasha-ruby see also this issue: https://github.com/bcgov/land-designations-shinyapp/issues/32