rcaaqs icon indicating copy to clipboard operation
rcaaqs copied to clipboard

Review cut_* functions for standard colours and categories

Open ateucher opened this issue 8 years ago • 3 comments

Some of the colours chosen are design choices we have made for our specific reporting requirements but are not mandated by caaqs. Should probably pull these out or generalize them so other people can make their own design choices.

ateucher avatar Jun 09 '17 17:06 ateucher

I think it's probably ok to hard-code the management level colours, but perhaps achieved/not achieved should be customizable?

ateucher avatar Nov 28 '18 23:11 ateucher

Agreed—achieved/not achieved/insufficient data could be provided.

stephhazlitt avatar Nov 28 '18 23:11 stephhazlitt

The colours are currently used in the exported get_colours() which we use to generate static plots/maps of the results—it would be good for a user to decide on the not-prescribed achievement ones for sure. I am on the fence a bit about whether the cut_*() functions need to be exported.

stephhazlitt avatar Nov 28 '18 23:11 stephhazlitt