Create/Edit UI and Legal API: Party name length validation inconsistency between filings.

[loneil]

Note: this may be expected behavior but just logging to confirm as part of validation analysis.

In an Incorporation Application the First Name and Middle Name are restricted to 20 characters. This is done in the Create UI FE and also validated in the Legal API (the validation on the API call, not the schema in this case)

But then after that you can file a Change of Directors and can then set the Director name to longer than 20 characters. CoD then uses the 30 char limit from the schema, see directors and party.

See comment in common_validations.py

def validate_parties_names(filing_json: dict, filing_type: str, legal_type: str) -> list:
    """Validate the parties name for COLIN sync."""
    # FUTURE: This validation should be removed when COLIN sync back is no longer required.
    # This is required to work around first and middle name length mismatches between LEAR and COLIN.
    # Syncing back to COLIN would error out on first and middle name length exceeding 20 characters for party
    msg = []

So probably intended for now in Incorporation Application, but is it ok for Change of Directors to allow the change then?