SIMSBIOHUB-623: Add Site Name and Description When Creating New Sampling Site
Links to Jira Tickets
- https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-623
Description of Changes
- Allows a name and description to be added to a sampling site during creation
Testing Notes
- Can only name/describe a sampling site during creation when exactly one site is being added
Openshift URLs for the PR Deployment:
- App Route: https://biohubbc-app-1386-af2668-dev.apps.silver.devops.gov.bc.ca/
- Api Route: https://biohubbc-api-1386-af2668-dev.apps.silver.devops.gov.bc.ca/
- Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1386
Codecov Report
Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
Project coverage is 46.34%. Comparing base (
f347e26) to head (6174566). Report is 1 commits behind head on dev.
Additional details and impacted files
@@ Coverage Diff @@
## dev #1386 +/- ##
==========================================
- Coverage 46.37% 46.34% -0.03%
==========================================
Files 781 782 +1
Lines 21106 21116 +10
Branches 3165 3166 +1
==========================================
Hits 9787 9787
- Misses 10735 10745 +10
Partials 584 584
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Openshift URLs for the PR Deployment:
- App Route: https://biohubbc-app-1386-af2668-dev.apps.silver.devops.gov.bc.ca/
- Api Route: https://biohubbc-api-1386-af2668-dev.apps.silver.devops.gov.bc.ca/
- Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1386
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Looks good!
Only minor thing I noticed is the difference of the sampling site description input and the technique description. Might be nice to include the optional / max character count for the sampling site description too.
Sampling Site description:
Technique description: