biohubbc icon indicating copy to clipboard operation
biohubbc copied to clipboard

SIMSBIOHUB 587: API Measurements

Open MacDeluca opened this issue 1 year ago • 3 comments

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

MacDeluca avatar Aug 20 '24 21:08 MacDeluca

Openshift URLs for the PR Deployment:

  • App Route: https://biohubbc-app-1344-af2668-dev.apps.silver.devops.gov.bc.ca/
  • Api Route: https://biohubbc-api-1344-af2668-dev.apps.silver.devops.gov.bc.ca/
  • Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1344

github-actions[bot] avatar Aug 20 '24 21:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 76.72956% with 37 lines in your changes missing coverage. Please review.

Project coverage is 47.17%. Comparing base (bb4f7dd) to head (d9f96f2). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
.../survey/{surveyId}/critters/measurements/import.ts 0.00% 21 Missing :warning:
...rvices/measurement/import-measurements-strategy.ts 89.21% 4 Missing and 7 partials :warning:
...surement/import-measurements-strategy.interface.ts 0.00% 3 Missing :warning:
...mport-services/capture/import-captures-strategy.ts 92.85% 0 Missing and 1 partial :warning:
...mport-services/marking/import-markings-strategy.ts 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1344      +/-   ##
==========================================
+ Coverage   47.01%   47.17%   +0.16%     
==========================================
  Files         738      741       +3     
  Lines       19887    20014     +127     
  Branches     3062     3084      +22     
==========================================
+ Hits         9350     9442      +92     
- Misses       9969     9997      +28     
- Partials      568      575       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 22:08 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Sep 04 '24 23:09 sonarqubecloud[bot]