biohubbc icon indicating copy to clipboard operation
biohubbc copied to clipboard

SIMSBIOHUB-567: Support Observation Environment Attributes

Open NickPhura opened this issue 1 year ago • 4 comments

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-567

Description of Changes

Add new UI to support environment columns in observations table. Add new db tables for environment attribute codes.

Testing Notes

Can add/remove environment attribute columns in observations table. Can add/remove environment column cell values.

NickPhura avatar Apr 23 '24 19:04 NickPhura

Openshift URLs for the PR Deployment:

  • App Route: https://biohubbc-app-1278-af2668-dev.apps.silver.devops.gov.bc.ca/
  • Api Route: https://biohubbc-api-1278-af2668-dev.apps.silver.devops.gov.bc.ca/
  • Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1278

github-actions[bot] avatar Apr 23 '24 19:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 21.40175% with 628 lines in your changes are missing coverage. Please review.

Project coverage is 52.30%. Comparing base (a9b6e80) to head (91d8213). Report is 1 commits behind head on dev.

:exclamation: Current head 91d8213 differs from pull request most recent head e8bde68. Consider uploading reports for the commit e8bde68 to get more accurate results

Files Patch % Lines
app/src/contexts/observationsTableContext.tsx 0.00% 103 Missing :warning:
api/src/services/observation-service.ts 6.02% 78 Missing :warning:
...on-row-validation/ObservationRowValidationUtils.ts 5.66% 50 Missing :warning:
...ironment/search/EnvironmentsSearchAutocomplete.tsx 0.00% 45 Missing :warning:
...nts/environment/useConfigureEnvironmentColumns.tsx 0.00% 45 Missing :warning:
...ies/observation-subcount-environment-repository.ts 22.00% 39 Missing :warning:
...ts/measurements/useConfigureMeasurementColumns.tsx 0.00% 30 Missing :warning:
...table/configure-columns/ConfigureColumnsButton.tsx 0.00% 21 Missing :warning:
...vey/{surveyId}/observations/environments/delete.ts 0.00% 19 Missing :warning:
.../components/general/useConfigureGeneralColumns.tsx 0.00% 18 Missing :warning:
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1278      +/-   ##
==========================================
- Coverage   53.12%   52.30%   -0.82%     
==========================================
  Files         562      577      +15     
  Lines       16432    16871     +439     
  Branches     2552     2610      +58     
==========================================
+ Hits         8729     8824      +95     
- Misses       7119     7459     +340     
- Partials      584      588       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 23 '24 19:04 codecov-commenter

Openshift URLs for the PR Deployment:

  • App Route: https://biohubbc-app-1278-af2668-dev.apps.silver.devops.gov.bc.ca/
  • Api Route: https://biohubbc-api-1278-af2668-dev.apps.silver.devops.gov.bc.ca/
  • Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1278

github-actions[bot] avatar May 07 '24 21:05 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 15 '24 21:05 sonarqubecloud[bot]

Replaced by https://github.com/bcgov/biohubbc/pull/1289

NickPhura avatar May 16 '24 18:05 NickPhura