bc-wallet-mobile icon indicating copy to clipboard operation
bc-wallet-mobile copied to clipboard

Link in message missing link accessibillity label

Open knguyenBC opened this issue 2 years ago • 5 comments

Description of problem

In messages that are sent from a contact that contains a link, the link is missing the "link" accessibility label/role. When focused, the link is read out but a non-sighted person will not know if it's a link they can tap.

Expected behavior

Should contain the link accessibility role/label. It normally reads out as "[text of hyperlink]...Link"

Steps to reproduce

  • Send a message with a link to a contact
  • turn on voice over
  • swipe over to the message with a link

Screenshots and/or log output

Environment

  • [X] Occurs on Android
  • [X] Occurs on iOS

Build #: 1193

Android Device Model: OnePlus 6

iOS Device Model: iPhone SE

Workaround

Severity

  • [ ] High
  • [ ] Medium
  • [X] Low

knguyenBC avatar Sep 12 '23 16:09 knguyenBC

The accessibilityRole of link in nested Text elements is not picked up on iOS until RN 0.69, so we'll have to wait until after our React Native upgrade to fix this one

bryce-mcmath avatar Sep 14 '23 00:09 bryce-mcmath

resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/998

wadeking98 avatar Oct 17 '23 00:10 wadeking98

Tested on 1.0.12 1325 and I don't see any accessibility labels on the link in chat:

IMG_9D0F150ADF20-1

jleach avatar Nov 23 '23 22:11 jleach

Until we start using the new RN architecture (with Fabric) inline nested links will not have accessibility features. This can be avoided in the interim by using the Link component outside of the text surrounding it. It's not an elegant solution but it's the only one that works for now

bryce-mcmath avatar Nov 23 '23 22:11 bryce-mcmath

This may require a re-think. Moving out of this sprint to est ready.

jleach avatar Dec 01 '23 17:12 jleach