SIMS icon indicating copy to clipboard operation
SIMS copied to clipboard

#4652 - PR 1: Convert currency inputs to number-currency

Open ninosamson opened this issue 7 months ago • 5 comments

  • Converts all currency inputs to use new "number-currency" custom component, which includes validation for negative numbers, delimiter, and no decimals.

image

  • This PR includes the following files:
    • partner information income appeal
    • report scholastic standing change
    • sfaa2024-25
    • supporting users parent 2024-25
  • includes fix to icon for number-currency component

ninosamson avatar May 27 '25 23:05 ninosamson

Finished first round of review @ninosamson. Please have a look at the comments.

dheepak-aot avatar May 29 '25 16:05 dheepak-aot

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.81% ( 4055 / 18591 )
Methods: 9.85% ( 234 / 2376 )
Lines: 25.14% ( 3502 / 13930 )
Branches: 13.96% ( 319 / 2285 )

github-actions[bot] avatar May 29 '25 18:05 github-actions[bot]

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.48% ( 677 / 934 )
Methods: 73.45% ( 83 / 113 )
Lines: 74.54% ( 530 / 711 )
Branches: 58.18% ( 64 / 110 )

github-actions[bot] avatar May 29 '25 18:05 github-actions[bot]

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.04% ( 1528 / 1776 )
Methods: 83.98% ( 173 / 206 )
Lines: 88.37% ( 1261 / 1427 )
Branches: 65.73% ( 94 / 143 )

github-actions[bot] avatar May 29 '25 18:05 github-actions[bot]

E2E SIMS API Coverage Report

Totals Coverage
Statements: 71.77% ( 6968 / 9709 )
Methods: 69.78% ( 859 / 1231 )
Lines: 75.2% ( 5407 / 7190 )
Branches: 54.5% ( 702 / 1288 )

github-actions[bot] avatar May 29 '25 18:05 github-actions[bot]