bcgov
BUG: FT PY 25/26: No error handling on fields allows negative values accepted causing excessive need
Describe the Bug FT PY 25/26: No error handling on fields allows negative values causing possible excessive need
Acceptance Criteria for Fix:
Changes to made to PY24/25 onwards for supporting user and student forms. Changes will also be applied to financial information appeal (student/partner) and scholastic standing reporting.
- [ ] add custom validation to prevent negative numbers to all currency inputs
- [ ] change all currency inputs to number inputs (use CA$ Prefix)
- [ ] ensure conditional logic from currency inputs pulls over
- [ ] create new number currency component for re-use
- Header-Large as example - https://github.com/bcgov/SIMS/blob/0b30fc6dbba027f2d72ca7b3d9e78edbc935946c/sources/packages/web/src/types/formio/custom-components/headers/header-large.ts#L1
Expected Behaviour Error handling occurs for all data entry fields
Error message: "The number you have entered is outside the expected range." is displayed for negative numbers Unstyled red font for error messages
When Next is select, standard SIMS Standard SIMS handling
(Will any of the below be removed for FT)
Actual Behaviour Students can add negative numbers and the assessment is processed with negative values
Example
-
[ ] FT app only: Implement component with validation for min/max
-
[ ] Identify other inputs that are not capture in the ticket
-
[ ] Add error handling to the following fields
-
Content for error messages that are not within range: "The number you have entered is outside the expected range."
-
Unstyled red font error message
-
Standard SIMS border around the field and added to "Please fix the following errors before submitting"
Partner information tab
- [ ] If your partner will be a full-time student, how many weeks of your study period will they also be in studies
- [ ] Enter amount that your partner will pay during your study period. (for the Canada Student Loan question)
- [ ] Enter amount that your partner will pay during your study period. (for the child support and/or spousal support question)
Financial information tab
- [ ] Enter the amount that you will pay during your study period. (dependant care costs)
- [ ] Enter the amount that you will receive from merit-based...
- [ ] Enter the amount the estimated amount of B.C. income assistance
- [ ] Enter the amount of government funding (for EI training allowance)
- [ ] Enter the amount of non-government (private sector)
- [ ] Enter the estimated amount that you will receive (voluntary contributions)
- [ ] If you must relocate
Steps To Reproduce
Precondition: FT offerings for PY 25/26 Student can create an application
- Login to the student portal
- Click "start application"
- Select “Full-time” for the capacity
- Select the 25/26 program year
- Click “start application”
Program Tab 6. Select the institution for institution selection 7. Note the "Full-time" for capacity 8. Select the program of study 9. Select the study dates (offering)
Personal information tab 10. Click "I confirm my StudentAid BC Profile that is shown above is correct" 11. Select "Canadian citizen" for citizenship status 12. Select “married” for marital status 13. Select "no" for identifying as indigenous person 14. Select "no" for child or youth under government care 15. Select “no” for time of your course of study 16. Enter any date you graduated high school (can be today’s date) 17. Select “no” for since time you left high school 18. Select “no” for eligible dependants 19. Select “yes” for parents are deceased 20. Select “yes” for estranged from both my parents 21. Select "no" for disability information 22. Select “yes” for resident of B.C. 23. Select "no" for trusted contact
Partner information tab 24. Select "yes" for your spouse/common-law eligible for a BC services Card 25. Select "yes" to declare your spouse/common-law partner's estimated current year gross income 26. Enter a negative number for "my spouse/common-law current year gross income" 27. Note the error "the number you have entered is outside the expected range." 28. Select any reason 29. Drop a file to be uploaded 30. Select "no" to the next six questions 31. Select "yes" for will your partner be a full-time post secondary student 32. Enter a negative number for number of weeks, note below the field 33 Select "yes" for will your partner be paying a Canada Student Loan 34. Enter a negative number for "amount that your partner will pay during your study period", note below the field 35. Select "yes" for will your partner be paying for child support 36. Enter a negative number for "amount that your partner will pay during your study period", note below the field 37. Select "no" for eligible dependants 38. Click "Next"
Financial Information Tab 39. Enter any income 40. Select " I give the Canada Revenue Agency...." 41. Select "no" for financial circumstances 42. Select “no” for financial exceptional expenses (error handling occurs) 43. Select “yes” for dependant care costs 44. Enter a negative number for "enter the amount that you will pay during your study period", note below the field 45. Select “yes” for merit-based 46. Enter a negative number for merit based scholarships, note below the field 47. Select “yes” for B.C. income assistance 48. Enter a negative number for B.C. income assistance, note below the field 49. Select “yes” for government funding (e.g. EI) 50. Enter a negative number for government funding, note below the field 51. Select “yes” for non-government funding (e.g. Private sector) 52. Enter a negative number for non-government funding, note below the field 52. Select “yes” for receive voluntary contributions 53. Enter a negative number for the contributions that you will receive, note below the field 54. Select “no” for living in a home 55. Select “yes” for must relocate 56. Enter amount for must relocate, note the below the field 57. Select “no” for additional transportation 58. Click "Next", note any error messages
Note: tagging this as formeditor, as the currency component can be made available to the formeditor. We can then just replace all the inputs identified with this currency component.
@ninosamson Hi Nino, did you introduce validations on Partner's and Parents forms as well? If not, I will create tickets for those ones. Thank you,
Hi @AnnaPBashkatova, I updated all forms where currency was collected, but the left the following, as they were from previous, no longer used program years.
