SIMS icon indicating copy to clipboard operation
SIMS copied to clipboard

#3193 - New OCP Routes

Open andrewsignori-aot opened this issue 1 year ago • 5 comments

Main changes

  • Added certificate, key, and caCertificate to routes.
  • Added the proposed annotations to the same routes. Information about the route annotations and its intentions can be found in route-specific-annotations_route-configuration.
  • Renamed the routes (now sims.studentaidbc.ca) to allow both routes to exist at the same time for now.
  • Only the certificate contents are provided as parameters to allow the correct line-breaking.

Additional Steps

  • Change Keycloak properties for: aest, institution, student, and supporting-users.
    • Valid Redirect URIs: https://dev.sims.studentaidbc.ca/*
    • Web Origins: https://dev.sims.studentaidbc.ca
  • Created a new GitHub variable DOMAIN_PREFIX (created as a regular var because it is not sensitive).
  • Create the new variables TLS_CERTIFICATE, TLS_KEY, TLS_CA_CERTIFICATE. These were not added to the sample config because there is no reason for them to exist in the local environment.

Non-directly related change

  • FORMIO_ROOT_EMAIL and FORMIO_ROOT_PASSWORD are no longer regenerated at every form.io server deployment to avoid credentials reconfigurations along the applications. The credentials should be changed due to a password rotation process and not during the server update.

TODO

  • Ensure release instructions for the Additional Steps above.

andrewsignori-aot avatar Aug 21 '24 17:08 andrewsignori-aot

E2E SIMS API Coverage Report

Totals Coverage
Statements: 64.03% ( 5230 / 8168 )
Methods: 60.73% ( 631 / 1039 )
Lines: 68.3% ( 4144 / 6067 )
Branches: 42.84% ( 455 / 1062 )

github-actions[bot] avatar Aug 22 '24 20:08 github-actions[bot]

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.91% ( 3412 / 15576 )
Methods: 10.01% ( 195 / 1949 )
Lines: 25.59% ( 3004 / 11740 )
Branches: 11.29% ( 213 / 1887 )

github-actions[bot] avatar Aug 22 '24 21:08 github-actions[bot]

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

github-actions[bot] avatar Aug 22 '24 21:08 github-actions[bot]

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 82.14% ( 952 / 1159 )
Methods: 83.47% ( 101 / 121 )
Lines: 83.93% ( 820 / 977 )
Branches: 50.82% ( 31 / 61 )

github-actions[bot] avatar Aug 22 '24 21:08 github-actions[bot]

@andrewsignori-aot

E2E test seems failed in this PR, it needs to pass all E2E test?

bidyashish avatar Aug 26 '24 16:08 bidyashish

@andrewsignori-aot

E2E test seems failed in this PR, it needs to pass all E2E test?

The failed tests are intermittent issues that also exist in other PRs. The ticket #3652 was created a few days ago to investigate those.

andrewsignori-aot avatar Aug 26 '24 17:08 andrewsignori-aot