PIMS icon indicating copy to clipboard operation
PIMS copied to clipboard

PIMS-1685: Agency Response Workflow

Open GrahamS-Quartech opened this issue 1 year ago • 3 comments

🎯 Summary

PIMS-1685

The goal of this ticket is to integrate the frontend components for agency interests with the backend for updating the project and sending notifications.

  • Added submit and retrieve logic between frontend and backend for agency interest responses.
  • Fixed several logic issues in the sequence of events for updating the project as well as issues where notifications would be created but not sent.
  • Added editable fields to the agency interest table for Received On and Note.
  • Fixed minor issues with the autocomplete form field that could raise an error and make it stop working as expected.

~~Note: Currently interests only get set to 1 for "Subscribed". Need Josh to confirm expected behavior from the different interest types.~~ Actually, I updated this so that you can select the response type. I still think we may end up pairing this down to just Unsubscribed and Subscribed though.

🔰 Checklist

  • [x] I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

GrahamS-Quartech avatar May 13 '24 22:05 GrahamS-Quartech

🚀 Deployment Information

The Express API Image has been built with the tag: 2383. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

github-actions[bot] avatar May 13 '24 22:05 github-actions[bot]

🚀 Deployment Information

The React APP Image has been built with the tag: 2383. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

github-actions[bot] avatar May 13 '24 22:05 github-actions[bot]

Code Climate has analyzed commit ff1ff6c6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 52.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.2%.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar May 13 '24 22:05 qlty-cloud-legacy[bot]

Seem to be getting this error now.

Should be fixed I think, lemme know. Changing the empty value to null suppresses this value but I've also had issues with it being null in the past.

GrahamS-Quartech avatar May 16 '24 23:05 GrahamS-Quartech