PIMS-1543: Unable to add a net book or assessed values when none exist

[LawrenceLau2020]

🎯 Summary

PIMS-1543:

Allowing users to add new net book and assessed values as well as editing existing values, sorting by year descending.

Please test adding and editing net book and assessed values to buildings and parcels when none exist, as well as when there are existing financial values. In the case where a property's net book or assessed values history does not have a value for the current year (2024), there should be a new text box to add a new value.

🔰 Checklist

• [x] I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[qlty-cloud-legacy[bot]]

Code Climate has analyzed commit 137280bc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.5%.

View more on Code Climate.

[GrahamS-Quartech]

I fixed some issues and optimized the behavior of the submit function for evaluations since buildings were not able to be saved.

There's other things I'm noticing with updating evaluations though. You can modify the year of an evaluation, but this does not appear to be accounted for in the backend logic, so if you change a row from 2021 -> 2023, reloading the page will show you two evaluations with 2021 and 2023 respectively. You can also enter any number of past or future years if you continuously save using the free row that gets added unless you enter the current year.

We need to either decide on a more rigid workflow for how these get added or expand the functionality to have more fleshed out CRUD features on these dialogs.