bc-java icon indicating copy to clipboard operation
bc-java copied to clipboard

Add missing methods for OpenPGP v6 API

Open vanitasvitae opened this issue 6 months ago • 1 comments

This PR contains some missing methods that were not yet merged in #1911

The PR was created by adding in missing functionality that the current v6 branch of PGPainless depends on, so it is not complete, but adds enough to make PGPainless compile and allow the tests to pass.

Hope this helps :)

vanitasvitae avatar Jun 16 '25 11:06 vanitasvitae

Some background on https://github.com/bcgit/bc-java/pull/2105/commits/c931f24a87d61e5188a796ee6fb8a727141f50ee : I'd like to keep this a (functional) interface if possible. The factory methods can be moved into another class (as I did -> Util), but keeping the class an interface enables implementers to simply provide a lambda expression when a KeyPairGeneratorCallback object is required.

vanitasvitae avatar Jun 17 '25 08:06 vanitasvitae

Do you have any plans on when this PR can be merged? I'd like to make a new PGPainless release using the new v6 API at some point but the missing changes already blocked me from making a release using BC 1.81, which was a bit unfortunate.

vanitasvitae avatar Jun 30 '25 13:06 vanitasvitae

@vanitasvitae Thanks for the update! The final reviewer is currently on leave and will be back next Monday. In the meantime, I plan to push the branch into the final review phase by this Friday, so it’ll be ready for them upon return.

Appreciate your patience. I’ll do what I can to keep things moving.

ligefeiBouncycastle avatar Jul 03 '25 01:07 ligefeiBouncycastle

This is apparently now part of main :)

vanitasvitae avatar Aug 25 '25 20:08 vanitasvitae