bc-csharp icon indicating copy to clipboard operation
bc-csharp copied to clipboard

Added netstandard2.1 to the build targets

Open jstedfast opened this issue 1 year ago • 0 comments

Describe your changes

There are a number of APIs in BouncyCastle that are conditionally enabled (such as APIs that make use of ReadOnlySpan<T>) when #if NETSTANDARD2_1_OR_GREATER evaluates to true.

This causes issues if any library that references BouncyCastle targets netstandard2.1 (and would therefore build against the netstandard2.0 version of BC) if it is itself referenced by an app (or other library) that targets net6.0+, resulting in a "missing implementation" error.

Fixes issue #447 (at least in a practical sense)

How has this been tested?

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I have kept the patch limited to only change the parts related to the patch
  • [ ] This change requires a documentation update

See also Contributing Guidelines.

jstedfast avatar Dec 20 '24 15:12 jstedfast