bc-csharp icon indicating copy to clipboard operation
bc-csharp copied to clipboard

[BUG] unnecessary lock statements

Open zivillian opened this issue 1 year ago • 0 comments

Describe the Bug

I'm tracing my application for increased CPU usage after switching from openssl to bc-csharp and my profiler shows a lot of time is spent in AbstractTlsContext.get_SecurityParameters()

I'm not yet sure if this is the reason for the increased CPU usage in my application, but as far as I can tell the lock statement in all those properties will not do anything useful and may decrease the performance.

I'm happy to create a PR which removes the locks in this class, but I wanted to make sure, that I haven't missed anything.

Screenshots and Logs

grafik

Product Deployment

Please complete the following information:

  • Deployment format: docker on arm
  • Version 2.4.0

zivillian avatar Sep 10 '24 19:09 zivillian