MagicaLogia zh hant

[zeteticl]

[ysakasin]

@zeteticl Thanks your PR.

Translated Dicebot does't work only YAML for i18n. Please commit these files.

• lib/bcdice/game_system/MagicaLogia_ChineseTraditional.rb
  • Translate HELP_MESSAGE from MagicaLogia.rb.
  • e.g.: https://github.com/bcdice/BCDice/blob/master/lib/bcdice/game_system/MagicaLogia_SimplifiedChinese.rb
• test/data/MagicaLogia_ChineseTraditional.toml
  • Translate test cases from test/data/MagicaLogia.toml
  • e.g.: https://github.com/bcdice/BCDice/blob/master/lib/bcdice/game_system/MagicaLogia_SimplifiedChinese.rb

More details how to make translation files here (JA): https://github.com/bcdice/BCDice/wiki/%E7%BF%BB%E8%A8%B3%E3%81%AE%E5%AF%84%E7%A8%BF%E3%82%AC%E3%82%A4%E3%83%89

[zeteticl]

@ysakasin Fixed~ Thankyou~!

[codecov[bot]]

Codecov Report

Merging #479 (ff99162) into master (8f24f72) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   95.35%   95.36%           
=======================================
  Files         292      293    +1     
  Lines       18744    18759   +15     
=======================================
+ Hits        17874    17889   +15     
  Misses        870      870           

Impacted Files	Coverage Δ
lib/bcdice/game_system.rb	100.00% <100.00%> (ø)
...dice/game_system/MagicaLogia_ChineseTraditional.rb	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f24f72...ff99162. Read the comment docs.

[ysakasin]

@zeteticl

I fix tiny mistakes, but the test still failing due to difference of translation between test/data/MagicaLogia_ChineseTraditional.toml and i18n/MagicaLogia/zh_hant.yml.

Could you fix these? Points that need to be corrected are available from test log.

[ysakasin]

@zeteticl

I will close this Pull Request, but you are welcome to re-open it if you have any new progress.