bmm-web icon indicating copy to clipboard operation
bmm-web copied to clipboard

Windows: restore window as maximized

Open kkuepper opened this issue 1 year ago • 2 comments

Right now, it's not restored as maximized. Since I have a Mac it would be a lot easier if someone working on Windows could work on this.

See electron/main.ts where window.setBounds() is called. https://github.com/electron/electron/issues/526 should give some hints on how to fix it.

kkuepper avatar Feb 10 '24 10:02 kkuepper

There is definitively something to fix here. I am not sure if it should be maximized by default, but a bit bigger would be great by default. When I first opened it, it looked like this on my screen:

image

resolution 1920x1080 (1080p).

leo-schick avatar Apr 10 '24 20:04 leo-schick

@leo-schick For now, we're just using a safe size that doesn't cause problems. It would be better to increase the size if the screen has more space, but that requires additional code.

Also, it's only relevant the first time you open the app. After that it uses the screen size it had when it was closed.

Feel free to create a PR: https://github.com/bcc-code/bmm-web/blob/main/electron/main.ts

kkuepper avatar Apr 11 '24 14:04 kkuepper