bccm-player icon indicating copy to clipboard operation
bccm-player copied to clipboard

Feature: Buffering configuration for android

Open andreasgangso opened this issue 1 year ago • 7 comments

This is a good first issue.

  1. Create a class in playback_platform_pigeon.dart (see pigeons readme), something similar to [betterplayers BufferingConfiguration], something similar to betterplayers BufferingConfiguration
  2. Pass it as argument to newPlayer() because you probably can't change it for an existing exoplayer.
  3. ExoPlayerController just needs to setLoadControl() with the values. Something like this: https://github.com/jhomlala/betterplayer/blob/f6a77cf6fbb515f01aa9fb459b2ee739de3e724c/android/src/main/kotlin/com/jhomlala/better_player/BetterPlayer.kt#L101

andreasgangso avatar Aug 03 '23 09:08 andreasgangso

any docs for using controller.gettracks and setSelectedTrack,

@andreasgangso

sudhanshugairola avatar Aug 09 '23 17:08 sudhanshugairola

yes its documented in the code so your editor should show it when you hover the methods. You can also read the settings.dart here on github for how its used it the default flutter controls.

Message ID: @.***>

andreasgangso avatar Aug 09 '23 17:08 andreasgangso

Not default one I'm saying about list of track by controller and selection

sudhanshugairola avatar Aug 09 '23 17:08 sudhanshugairola

all set one thing is missing how to get subtitles in text my controller? controller.renderedSubtitle!.texts

is see this bug in video_player miisng some special characters?

sudhanshugairola avatar Aug 09 '23 18:08 sudhanshugairola

You can check what subtitles are available with getTracks(). But if you mean the actual subtitle file contents: there is no way to get the subtitles as a stream or anything like that. This plugin uses a different approach than betterplayer. bccm_player leaves subtitle rendering completely to the native player. I don’t see any benefits of changing this as it only creates overhead. but if you need that then by all means open an issue outlining why you need this and what problem it would solve.

Sendt fra Outlook for iOShttps://aka.ms/o0ukef


Fra: Sudhanshu Gairola @.> Sendt: Wednesday, August 9, 2023 8:06:53 PM Til: bcc-code/bccm-player @.> Kopi: Andreas Gangsø @.>; Mention @.> Emne: Re: [bcc-code/bccm-player] Feature: Buffering configuration for android (Issue #2)

all set one thing is missing how to get subtitles in text my controller?

— Reply to this email directly, view it on GitHubhttps://github.com/bcc-code/bccm-player/issues/2#issuecomment-1671903645, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFRQVIEMA3CKK2LSTKYOHTXUPGT3ANCNFSM6AAAAAA3CQEX34. You are receiving this because you were mentioned.Message ID: @.***>

andreasgangso avatar Aug 09 '23 18:08 andreasgangso

some time user zoom in and out or pinch to far zoom then subtitle hide on if render subtitle available the solve that issue for user and set render subtitle text over on their UI.

sudhanshugairola avatar Aug 09 '23 18:08 sudhanshugairola

most of user complaint on better_player that issue finally they provide for far view of subtitle over native view

sudhanshugairola avatar Aug 09 '23 18:08 sudhanshugairola