Brandon Caton

Results 40 comments of Brandon Caton

It looks good but how will this save network requests in the future? Don't we still need to make the request for each sub-manifest anyway to get the size of...

ah okay now i understand. By having the calls happen only on render this means we can't get the manifest list size until the row is expanded. Makes sense

@nmaloof This is targeting the `redhat-3.11` branch, can you retarget this to the `master` branch?

I think that was your best choice, the histories of redhat-3.11 and master have diverged quite a bit. It's easiest to just cherrypick it

it's only a part of the look up if `ids_only` if false. I believe there are calls where `ids_only` is true and this fails

`filter_username` is used in the calling function to filter the repository list to include those that the authenticated user has access too, e.g. private repos. [That is done here.](https://github.com/quay/quay/blob/master/data/model/repository.py#L416-L430)