Master commits break projects using the latest version

[marioarranzr]

Hi, @bbyars thanks for this project, super useful library for bdd tests and reproducing different scenarios.

We've recently had an issue due to a change in the entrypoint in the master branch so I thought I would open a ticket to ask for branch commits instead of committing to master directly. I know we should have pointed to a version tag instead of to latest but I think it's a good practise that is worth mentioning.

Thanks again for all the effort maintaining the library!

[bbyars]

Thanks Mario. I’m not sure I understand the concern though. Are you using the source code directly or public repos like npm and DockerHub where the branch doesn’t matter? If you are linked to the source directly, mind sharing a bit about your workflow? -Brandon

On Tue, Oct 18, 2022 at 3:09 AM Mario Arranz @.***> wrote:

Hi, @bbyars https://github.com/bbyars thanks for this project, super useful library for bdd tests and reproducing different scenarios.

We've recently had an issue due to a change in the entrypoint https://github.com/bbyars/mountebank/commit/06a477c62df99d6c97356ca67ebc3f460308e9f3 in the master branch so I thought I would open a ticket to ask for branch commits instead of committing to master directly. I know we should have pointed to a version tag instead of to latest but I think it's a good practise that is worth mentioning.

Thanks again for all the effort maintaining the library!

— Reply to this email directly, view it on GitHub https://github.com/bbyars/mountebank/issues/709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAARFP6K7LRD26EVHQIU2QLWDZZNLANCNFSM6AAAAAARH5HHCM . You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from Gmail Mobile

[marioarranzr]

When using docker and referring to the library as image: bbyars/mountebank it points to master directly, so it's up to date with every master commit. I know that is not the best practise, it should always point to a specific tag (image: bbyars/mountebank:2.8.1). But I thought it was worth mentioning that committing to a branch and merge once it works is cleaner and groups related commits in a single commit to master.

[brunns]

There are certainly those who argue the opposite, that trunk based development is the better way to go.