mountebank icon indicating copy to clipboard operation
mountebank copied to clipboard

`Dockerfile` manifest should make use of `ENTRYPOINT["mb"]` instead

Open x80486 opened this issue 3 years ago • 3 comments

While trying Mountbank via Docker, I believe the manifest should make use of ENTRYPOINT instead of CMD["mb"]; e.g.: ENTRYPOINT["mb"].

x80486 avatar Mar 31 '22 01:03 x80486

Can you share a bit more detail? What would that solve/prevent?

bbyars avatar Jul 17 '22 21:07 bbyars

In short, CMD defines default commands and/or parameters for a container. In my experience, I use CMD to default command(s) which users can easily override. In a different situation, ENTRYPOINT is used when defining a specific executable for a container.

Since mb is a must, then ENTRYPOINT makes more sense, and users, if desired, can pass more parameters to it.

x80486 avatar Jul 18 '22 10:07 x80486

Make sense, thanks.

On Mon, Jul 18, 2022 at 5:59 AM x80486 @.***> wrote:

In short, CMD defines default commands and/or parameters for a container. In my experience, I use CMD to default command(s) which users can easily override. In a different situation, ENTRYPOINT is used when defining a specific executable for a container.

Since mb is a must, then ENTRYPOINT makes more sense, and users, if desired, can pass more parameters to it.

— Reply to this email directly, view it on GitHub https://github.com/bbyars/mountebank/issues/671#issuecomment-1187071466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAARFPYV2YQHFWVCKUQWF4LVUU2INANCNFSM5SDXWM4Q . You are receiving this because you commented.Message ID: @.***>

bbyars avatar Jul 19 '22 01:07 bbyars