Bruce Blaser

Results 351 comments of Bruce Blaser

@Sboonny This is getting very close. Just a few things that need to be addressed. - We should get rid of the "Toggle Checkmark" sr-only text. The `aria-pressed` attribute will...

@Sboonny Concerning `aria-disabled`, after reading up on suggested patterns for exclusive toggle button groups, looking at real world implementations, and getting feedback from accessibility professionals who are much more seasoned...

> we can add a hidden input element inside the button with text "Run". I'm not sure if I am understanding this correctly, but if you mean that we should...

Personally, I am leery of overriding the default behavior of the virtual keyboard and I'm still not convinced this is going to work properly or be accessible, or even desirable....

Regarding toasts, which I'm assuming we mean messages that disappear after a certain amount of time without user intervention, they are inherently inaccessible and fail WCAG [SC 2.2.1](https://www.w3.org/WAI/WCAG21/Understanding/timing-adjustable.html) unless you...

If the streak information is going to continue to be displayed on the Profile page then yes, technically we can probably get away with using a toast here. But if...

I do have a few accessibility concerns about the On/Off toggle group. - Without the checkmark on the currently active button you can't really tell which one is active. Does...

I would also like to suggest that we might want to change the name of this component to something like ToggleButtonGroup so it is clear that this component represents a...

> We can swap that with `article` In all of the places I am finding where Panel is used I don't think any of them need to use an `article`,...

Just throwing out some more requirements/suggestions/questions on what we would need to do to enhance accessibility. - The user would need to know what tag the grid is currently filtered...