Bruce Blaser

Results 351 comments of Bruce Blaser

Yes, it appears that this used to be step 37 but now it is step 36. It also appears that the wording has been updated in step 36 to pretty...

> Any ideas on how to incorporate the `sr-only` class for this lesson? The first item under "Should Fix": > "Question 1" and "Question 2" sr-only text be added to...

A design question. When we have a button with a border, such as: ![fcc-button1](https://user-images.githubusercontent.com/5926192/223262655-64940538-73c7-4019-a16e-258e13c68e3e.png) Should the keyboard focus outline go around the outside of the border so that the border...

So of course I'm going to rain on the parade a little here. I apologize for not evaluating this sooner for accessibility. I didn't realize there was a drop down...

Hey @ahmadabdolsaheb, the current accessibility on these view buttons is not terrible, there are just a few things that could be improved regarding the functionality of the menu button itself...

One thing the Profile page should probably have is an `h1` heading near the top. I suppose we could convert the username that is currently an `h2`.

The FAQ disclosure buttons could use a little help as far as accessibility is concerned. Is that out of scope for this PR?

> My general philosophy is that if the behavior was preexisting, then it is outside the scope Makes sense. The FAQ button issue is pre-existing, so I will address it...

> What we could do is flip the variable we care about from trapped to free I gave myself a few days to think about this and I've come to...

Thanks for working with me and moving on this @ojeytonwilliams. It is much appreciated.