Performance-Fish icon indicating copy to clipboard operation
Performance-Fish copied to clipboard

Seemingly random unity crashes (RW 1.5, Modded)

Open D3nnis3n opened this issue 1 year ago • 14 comments

Hey there, since installation of Fishery I'm getting seemingly random Unity Crashes.

I have attached the crashdumps + playerlogs, might be related to Variety Matters? (VarietyMatters.New.Performance.FastLazy) I have confirmed that when Performance Fish is not active no crashes happen - but I am of course not sure if that makes Performance Fish the cause. Please feel free to let me know if there is a different mod that is the cause and I'll gladly let them know.

Thanks for the great performance boost. Crashes.zip

D3nnis3n avatar May 01 '24 07:05 D3nnis3n

It seems I mostly get these crashes when clicking either on a pawn or a storage containing food, but it's not always, rather like every 15 - 20 minutes.

D3nnis3n avatar May 01 '24 07:05 D3nnis3n

I can add to this: I get a guaranteed crash when linking together two storage containers. At first I thought it was an error with Eccentric Tech - Spacer Furniture's fridges, but I managed to crash on a minimum mod list of only Performance Fish plus its requisites. Removing Performance Fish allows linking together storage containers without the unrecoverable freeze. Player.log

Here's the steps I took to replicate it:

  1. Only have Rimworld + the 4 DLCs, Prepatcher, Harmony, Fishery, and Performance Fish
  2. Dev Quicktest
  3. Godmode then spawn two shelves and link them
  4. Game unrecoverably freezes

Jonblu11 avatar May 02 '24 02:05 Jonblu11

same thing happening to me....linking full shelves or food droppers crashes the game

Slinetina avatar May 02 '24 20:05 Slinetina

Just to clarify: I also got my crashes when clicking pawns and I never linked shelves, as I use LWM's Deep Storage. So I am not sure if we have the same cause. You might all also want to post your crash dumps / logs, you can find them in

%UserProfile%\AppData\Local\Temp\RimWorld by Ludeon Studios (Type into "run" to immediately go there)

They do get deleted if not taken out in good time, as its a temp folder, though. So best to do after you got a crash.

I'm not sure if the HugsLib Log is the same as the player log, that might also be helpful for the developer.

D3nnis3n avatar May 02 '24 20:05 D3nnis3n

I also have been having the random unity crashes. I think it has to do with LWM Storage, or Vanilla Framework expanded.

EDIT: I removed Deep Storage and have been playing without a crash for a while, I think the issue is there.

TonyRettich avatar May 03 '24 02:05 TonyRettich

I dont have Deep Storage but encounter this issues as well.

sunxyw avatar May 03 '24 06:05 sunxyw

I have only the 3 performance mods and it happens only when trying to link filled storage containers

Slinetina avatar May 03 '24 07:05 Slinetina

same crash when link storage containers

BR184 avatar May 04 '24 18:05 BR184

Confirming that linking storages does crash the game, which also started happening after I updated the performance fish and fishery. Before, it did not happen. Player.log

Cosmoros-git avatar May 04 '24 20:05 Cosmoros-git

Hi, I can add some data to this. I can produce this very reliably (although I don't know if it's the exact same problem as everyone else):

  1. Modlist is just:
  • prepatcher
  • harmony
  • core
  • performance fish
  • royalty
  • ideology
  • biotech
  • anomaly
  1. Open a devtest colony
  2. Pause
  3. use godmode to spawn in a stonecutter's bench, and a shelf
  4. rename the shelf test1
  5. add a bill to create a specific stone block like marble blocks (I have not been able to reproduce with "produce any stone block bill") and take to test1
  6. Unpause
  7. The game now crashes (actually it doesn't crash with a report, but rather it hangs until you force quit the process)

Some notes: I have not been able to get it to crash when saving the game before I unpaused and loading the game with the same settings that would have crashed it.

Edit: I think I narrowed it down to the exact patch: TryFindBestBetterStoreCellForWorker. Turning that off removes this particular crash.

0xc355 avatar May 04 '24 22:05 0xc355

same crash when link storage containers

BluerDR avatar May 05 '24 11:05 BluerDR

The storage linking crash should be solved now. The other variety matters crash mentioned once here originates from a fishery bug and will be fixed in the near future, after finalizing a refactor and verifying that it's not causing conflicts with other mods referencing the library

bbradson avatar Jun 16 '24 22:06 bbradson

The crash still exists.

a542557923 avatar Jul 26 '24 06:07 a542557923

The crash still exists.

To determine if the cause of your crash is the same as this one, could you try disabling the patches in the Performance Fish settings listed here? If the crash still occurs after disabling those settings and restarting the game, your bug is different from this one.

Alternatively, if the crash no longer occurs after doing that, could you find the version of Performance Fish in your RimWorld mod list?

fwdekker avatar Jul 26 '24 09:07 fwdekker