cargo-ndk icon indicating copy to clipboard operation
cargo-ndk copied to clipboard

Disable stripping if not a release build (?)

Open Fernthedev opened this issue 11 months ago • 2 comments

So I accidentally found that cargo-ndk strips the binaries by default. I am wondering what's the rationale for this decision. I tried looking for previous discussions related to this but only found the flag --no-strip was added.

I'm still rather curious as to why this decision was made, maybe perhaps the assumption was cargo-ndk would be used exclusively for release builds? Likewise, maybe we could find a way to only trigger stripping if it was originally desired, or remove altogether if cargo can be delegated to handle stripping through the cargo.toml file.

Not sure where else to make this change request. Thanks

Fernthedev avatar Jan 20 '25 21:01 Fernthedev

Next major release. 😁

bbqsrc avatar Mar 03 '25 21:03 bbqsrc

To add to this, the Android Gradle Plugin strips the libraries by default and add the symbols to the app bundle as metadata. Even for release, it would make more sense to not strip by default.

middagj avatar Jun 05 '25 11:06 middagj

This is removed in next major release.

bbqsrc avatar Jul 26 '25 10:07 bbqsrc

Fixed on main.

bbqsrc avatar Jul 26 '25 11:07 bbqsrc