Benny Bottema

Results 162 comments of Benny Bottema

You found the wrong project. The project has been continued here: https://github.com/better-js-logging/angular-logger.

> I couldn't make it work, it seems that MS encodes rich text with RTF which is... well, really painful. All the Outlook messages I've encountered do indeed have RTF...

Hey, thanks you so much for helping out! > This update modifies the constructors, to effectively pass configuration through constructors, rather than methods. So anyone after updating to this code,...

> > You also removed the examples for use in junit testing (although I admit I forgot to update this myself, when I switched to JUnit 5). > > I'm...

> > Perhaps, but it is what it is; this is how the library works right now. I'll let the users decide how to use it, but I don't want...

Alright, I had a quick look. I'm fine with the change.

Released in v4.1.0! Thanks again!

We have a regex somewhere that detects x500 address and since very recently we have a separate field for x500 address in Recipient (see https://github.com/bbottema/outlook-message-parser/issues/73 and https://github.com/bbottema/outlook-message-parser/pull/75). Perhaps we should...

@atmcq, I had a look at this and the issue stems from the fact we determine which address is a TO, CC and BCC, by comparing the 'display names' that...

@Shoocky I'm requiring the library distribution using webpack manually (instead of importing it from the source files), which I acquired from [Prism's download builder](http://prismjs.com/download.html?themes=prism&languages=markup+clike+java&plugins=normalize-whitespace). Then using Angular's `AfterViewChecked` lifecycle event...