Bryan Boreham

Results 969 comments of Bryan Boreham

good spot! We could prepend the supplied `server.Config.HTTPMiddleware` instead of appending it. Might need to tweak the opentracing handler. Or `server.Config` could have pre- and post- middleware.

I don't see why it _needs_ to be done that way. It is allowing non-authenticated access to `/ring`, but that doesn't seem essential.

What is the relevance to this repo, which is a set of library packages?

The specific problem described was addressed at #126. Do you still need options?

It means my tracing infrastructure is carrying extra data that is meaningless. It means I cannot use the `span.kind` tag to filter RPC client operations. Also I have a vague...

> It should be completely possible to migrate underlying dependencies without changing any API Yeah but not without making tracing stop working for everyone until they figure out how to...

Thanks for raising this. The code in that package was from https://github.com/grpc-ecosystem/grpc-opentracing, which does display a licence. I think we can assume this is an oversight in copying files rather...

> why the struct var is being overwritten it's a local variable, so not likely to cause a problem, but this was made less confusing in #193

Sorry I haven't been back here for a while. Code looks ok now; do you still want to merge it? Have you tried it out for real?

@joe-elliott ping on questions