Bryan Boreham

Thanks for the test; there appear to be a couple of points still outstanding from my first review - could you respond to those?

Hey, no apology required! I've re-pushed the branch so your new test should run in CI.

It looks like your `test/831_cni_plugin_ip_address_assignment_test.sh` is identical to the existing test 830; it should exercise the new feature.

We have no automated system to allow 3rd-party PRs access to the secrets; what I generally do is manually pull your branch and push it to the `weaveworks/weave` repo. Note...

> weave status ipam shows all IPs are available: It shows that all but 1 are available ("1 active"). `weave ps` should tell you where that IP is in use,...

I think your main problem is you left in all sorts of logic from the other test, including `BRIP=$(container_ip $HOST1 weave:expose)` which is allocating an address for the bridge. Strip...

Sorry, changed my mind, that line wouldn't do a `PUT` with a specific IP. I do recommend you strip down the test, but you'd need to find out where that...

Could you check if you have a pre-existing address on the `weave` bridge? Like `ip addr show dev weave`. You may want to do `weave reset --force` before running the...

I suspect the problem is happening here: https://github.com/weaveworks/weave/blob/34de0b10a69c2fa11f2314bfe0e449f739a96cd8/plugin/net/cni.go#L98 This part of the CNI plugin wants to set up a gateway address on the bridge so that egress traffic can be...

Thanks for the report. The file `/var/log/ulogd.pcap` is a named pipe (aka fifo) so perhaps some new restriction is preventing it from being created from the image. Could you please...