bblfsh
Make CI log in into github
To avoid "403 error limit rate exceeded" errors.
Note: once this is fixed, the workaround added in #307 should be removed.
@juanjux What's the environment variable where it needs to be defined? Note that this will not be defined for PR in forks.
@smola no idea, @dennwc was fighting with this but I think it didn't work (check #267) thus the current workaround.
@smola See https://github.com/dennwc/sdk/commit/fd734a1d8d8291d7f2620ca9f20c8d94e9cc2d69. And yes, it's a significant drawback that it cannot be used in PRs.
Not sure what are the action items here. What's left before closing this one?
Shall BABELFISH_GITHUB_TOKEN env var be set in the TravisCI repository settings for some repositories?
I've checked and it's already present in https://travis-ci.org/bblfsh/sdk/settings
Also not sure why exactly it cann't be used in PRs.
@bzz Secret environment variables cannot be used in PRs. It's by design on Travis to prevent secret leaks.
IMHO the rate limit errors should be avoided by using some kind of static manifest that can be retrieved without the API, but that's beyond the scope of this issue.
Right now the code will try to discover drivers using Github, and if it fails, it will download a static drivers list hosted in the documentation repo.
So can we remove this now?
I belive we can close this one then.
Secret environment variables cannot be used in PRs. It's by design on Travis to prevent secret leaks.
oh wow, thought that is applicably ONLY to encrypted variables defined in .yml but from https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings
Similarly, we do not provide these values to untrusted builds, triggered by pull requests from another repository.
Will close, as there is no further discussion.
But please, feel free to re-open if you think it's was not addressed/solved yet.
Tests are flaky again because we added another API call.
Assigning to @lwsanty to check if Travis provides us a Github token.