icewm icon indicating copy to clipboard operation
icewm copied to clipboard

unicode characters in a latin1 locale

Open gprints opened this issue 4 years ago • 1 comments

I'm running a de_DE.ISO8859-1 locale and icewm 1.9.2 is ignoring that and outputting unicode character sequences, e.g. in the Preferences Menu, it says "Aâ| - Lâ|" instead of "A... - L..." and a quick look into the source code reveals only a check of the font contains unicode characters, but no check for the locale. Do we really need unicode instead of just using three ASCII dots?

gprints avatar Nov 18 '20 12:11 gprints

Unicode ellipsis takes less space and also looks better, IMHO. Anyway, that situation can be solved by throwing an additional nl_langinfo check on it.

Code7R avatar Nov 18 '20 19:11 Code7R

The de_DE.ISO8859-1 locale looks fine to me. Is this still a concern?

gijsbers avatar Dec 02 '22 18:12 gijsbers

While the incorrect display got fiexed, I still wonder if a single unicode character is worth having a dependency to another library.

gprints avatar Dec 03 '22 07:12 gprints

Maybe not? How can I check this? Which library?

gijsbers avatar Dec 03 '22 10:12 gijsbers

Sorry, I was wrong. libiconv isn't being used for "...", it's hardcoded as #define utf8ellipsis "\xe2\x80\xa6" const unsigned utf32ellipsis = 0x2026;

But as far as the original bug is concearned, it got fixed.

gprints avatar Dec 05 '22 08:12 gprints