XUnity.AutoTranslator icon indicating copy to clipboard operation
XUnity.AutoTranslator copied to clipboard

Plugin.Core/Fonts/FontHelper.cs compares TextMeshPro version to Face Info version.

Open Lmeks opened this issue 1 year ago • 2 comments

Title. I've tried TMP versions 1.4.0, 2.0 something, 3.0.5, 3.0.9, and evrytiem XUnity.AutoTranslator complains that 'I use TextMeshPro vesion 1.1 but the application uses x.x.' Apparently it reads TMP version of a game correctly, but compares it to the version of something called "Face Info", which is not textmeshpro version, I don't know what it is (prolly a data packer), but it stays at v1.1 since TMP 1.4 up to TMP 3.0.9. 2024-11-17_23-55-26 2024-11-18_00-03-25 I couldn't find TMP version in the font's metadata in my cases.

Lmeks avatar Nov 17 '24 21:11 Lmeks

Anyway, if the unity can't read TMP atlas but loads the font, the characters which were not present in the game don't have any effects ingame (outline, shadows etc). If it reads the atlas but the font is too thin, it might appear black ingame if the outline is too thick. In case anyone was wondering.

Lmeks avatar Nov 17 '24 21:11 Lmeks

The code in question: https://github.com/bbepis/XUnity.AutoTranslator/blob/7b741c06c1add84c1576a6b31959b25bd90dfd03/src/XUnity.AutoTranslator.Plugin.Core/Fonts/FontHelper.cs#L75-L82

https://github.com/bbepis/XUnity.AutoTranslator/blob/7b741c06c1add84c1576a6b31959b25bd90dfd03/src/XUnity.AutoTranslator.Plugin.Core/Fonts/FontHelper.cs#L121-L128

Lmeks avatar Nov 18 '24 09:11 Lmeks