XUnity.AutoTranslator icon indicating copy to clipboard operation
XUnity.AutoTranslator copied to clipboard

TranslationScopeHelper.GetScope returns -1 instead of useful data

Open Lmeks opened this issue 1 year ago • 2 comments

I have to mention that the game this is happening in barely supports bepinex and the translator, but

TranslationScopeHelper.cs line 25 return GetScopeFromComponent( component ); It returns -1 in some cases, while it could pass GetActiveSceneId() to improve translation scoping. Would be nice to be able to use current scene name in translation files (eg #set scene sewers), because I couldn't access scene IDs without modifying the source code (CTRL + ALT + NP7 doesn't work, huh)

Lmeks avatar Nov 14 '24 01:11 Lmeks

Feel free to make a PR, seems like a reasonable change.

ManlyMarco avatar Nov 14 '24 16:11 ManlyMarco

I'm not that familiar with unity nor injection stuff nor C#, so I can't provide reasonable solution to "#set scene" proposal.

Lmeks avatar Nov 14 '24 18:11 Lmeks