PythonEditor icon indicating copy to clipboard operation
PythonEditor copied to clipboard

A11y: Modal close "button" should be keyboard focusable

Open microbit-carlos opened this issue 5 years ago • 0 comments

We can't focus the "x" close button via keyboard:

Screenshot 2020-11-17 at 15 05 07

We can still close the modal via escape key: https://github.com/bbcmicrobit/PythonEditor/pull/310

We could fix this via workaround, or if the modal library get's a fix upstream: https://github.com/HubSpot/vex/pull/134

More info in https://github.com/bbcmicrobit/PythonEditor/issues/347#issuecomment-728986198

microbit-carlos avatar Nov 17 '20 15:11 microbit-carlos