tal icon indicating copy to clipboard operation
tal copied to clipboard

Keyboard: DEL key not highlighted when 'delete' pressed on remote control

Open onionfx-work opened this issue 8 years ago • 1 comments

Hi, Triple tapping numbers on the remote control highlights the related keys (a-z, 0-9, SPACE) correctly.

However pressing 'delete' on the remote control does not highlight the DEL key onscreen.

I have a simple fix for this. Inside keyboard, _onKeyDownHandler there is a separate case for VK_BACK_SPACE and I'm simply setting the active child key (exactly how it is done when you reach the maximum allowed length of input).

} else if(evt.keyCode === KeyEvent.VK_BACK_SPACE) {
    if(this._currentText.length > 0) {
        this.setActiveChildKey('-');
        ...

I think I have this (whole) line ready with some tests :)

Thanks, Sam

onionfx-work avatar Jan 11 '17 11:01 onionfx-work

As per @tsadler1988 comments on #426 I believe this behaviour to be intentional. So I'm going to mark this as an enhancement.

subsidel avatar Dec 29 '17 11:12 subsidel

We have deprecated this project and there are no plans for active development going forward.

Please see the deprecation notice.

kukulaka avatar Jan 04 '23 17:01 kukulaka