tal icon indicating copy to clipboard operation
tal copied to clipboard

Allow different mask implementations in Carousels

Open jmcmaster956 opened this issue 8 years ago • 1 comments

All carousels currently extend from the carouselcore class. This class imports and sets the mask on the carousel from within the constructor, which means that is not currently possible to use a different mask implementation.

What would be very useful is to set a different mask to be used, that would allow us to extend the base mask class with some extended functionality and use this instead.

Have you any thoughts on the best way to do this within the framework? I can raise a pull request for this work

jmcmaster956 avatar Oct 19 '16 13:10 jmcmaster956

Hi,

Apologies for the delay in responding.

Using a different mask sounds entirely sensible - we actually override Mask.prototype to change the functionality, which is not ideal!

We would suggest adding an optional 3rd parameter in the Carousel Core constructor, named something like CustomMask or MaskConstructor, so you can pass in a custom mask constructor for it to use rather than the default.

Tom

tsadler1988 avatar Jan 05 '17 15:01 tsadler1988

We have deprecated this project and there are no plans for active development going forward.

Please see the deprecation notice.

Closing this issue as seems to be answeed by @tsadler1988

kukulaka avatar Jan 04 '23 17:01 kukulaka