sqs-consumer icon indicating copy to clipboard operation
sqs-consumer copied to clipboard

Published 20 hours ago • verified publisher icon bbc

SQS Consumer #223 allow zero for waitTimeSeconds

Open crh3675 opened this issue 5 years ago • 1 comments
trafficstars

Description

Response to issue https://github.com/bbc/sqs-consumer/issues/223

Allows 0 integer to be accepted as a valid input

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

crh3675 avatar Jun 29 '20 12:06 crh3675

This has been implemented in this commit and released at 5.7.0. I think we can close this.

Georift avatar May 23 '22 04:05 Georift

Based on the above comment and age, I am closing this.

Please open a new issue if this problem was not actually resolved.

nicholasgriffintn avatar Dec 08 '22 20:12 nicholasgriffintn

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Mar 17 '23 18:03 github-actions[bot]