simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

fix(deps): update dependency lru-cache to v7

Open renovate[bot] opened this issue 2 years ago • 2 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
lru-cache 6.0.0 -> 7.13.2 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Mar 23 '22 16:03 renovate[bot]

In previous versions, if the max value was null/undefined/0 it would default to an infinity value. This has changed therefore I had to use a fallback value. I am using 100 as fallback value as found here

Changelog difference that explains the above: Screenshot 2022-03-24 at 14 50 38

DarioR01 avatar Mar 24 '22 17:03 DarioR01

As Jro pointed out, the maxAge was deprecated in favour of ttl therefore that is the only change I have made to this PR.

The new version of the cache seems to work correctly. I printed the content of the cache and compared it with what we have on latest.

Latest: Screenshot 2022-05-26 at 09 56 39

lru-cache PR: Screenshot 2022-05-26 at 10 00 22

NB: The environment is live as I forced the fetch of live toggles.

DarioR01 avatar May 26 '22 09:05 DarioR01