simorgh
simorgh copied to clipboard
chore(deps): update dependency eslint-config-airbnb to v19
This PR contains the following updates:
Package | Change | Age | Adoption | Passing | Confidence |
---|---|---|---|---|---|
eslint-config-airbnb | 18.2.1 -> 19.0.4 |
Release Notes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, click this checkbox.
This PR has been generated by Mend Renovate. View repository job log here.
react/function-component-definition :
We should be consistent on the type of function we use to declare a React component. We already are and we mainly use arrow functions.
Action: This rule defaults to function expression, but we can set this to be arrow-function instead. There might be extreme cases where we are forced to use function expression due to a difference in scope between function expressions and arrow functions. However, we agreed to use the eslint disable comment that will disable this rule for each specific case.
react/no-invalid-html-attribute:
![Screenshot 2022-03-28 at 11 10 12](https://user-images.githubusercontent.com/90621252/160376610-effe18cc-f8ed-49d8-86cb-d58c4baf9c3b.png)
Whereas amphtml is not a valid rel:
According to Amp documentation, this is actually a valid rel.
Action: in cases where this library does not seem to correctly follow the documentation we agreed on deactivating the rule in a case-by-case scenario.
no-import-assign:
This rule conflicts with jest mocks, where we mock imported functions. We can either switch the rule off or switch it off case-by-case on every test file.
Action: https://github.com/bbc/simorgh/issues/10002
react/jsx-no-useless-fragment
Action: This rule is very welcome, please fix where we unnecessarily use React fragments in this PR.
react/jsx-no-constructed-context-values:
![Screenshot 2022-03-28 at 11 35 27](https://user-images.githubusercontent.com/90621252/160380754-41ee6850-c707-4267-849d-022f7cb54bda.png)
They suggest the usage of useMemo()
React hook.
Action: https://github.com/bbc/simorgh/issues/10003
react/no-unstable-nested-components:
Some are fixed by allowing as props, others persist and might require a case-by-case resolution.
Action: https://github.com/bbc/simorgh/issues/10007
import/no-import-module-exports:
![Screenshot 2022-03-28 at 11 58 55](https://user-images.githubusercontent.com/90621252/160384671-8f1aa752-87a4-4958-884f-13de24933d5f.png)
We should only import modules that get exported with the export method, if a module is exported through module.export we should use require.
Action: https://github.com/bbc/simorgh/issues/10005
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.
Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 19.x
releases. But if you manually upgrade to 19.x
then Renovate will re-enable minor
and patch
updates automatically.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.