simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

Implement some form of font regression/e2e tests

Open HarveyPeachey opened this issue 2 years ago • 0 comments

Is your feature request related to a problem? Please describe. When carrying out the font replacement work for Bengali, Sinhala and Tamil, it was noticed that there was next to no regression tests for these services, the only test that did fail was a snapshot for Most Read which detected a change in a single font size change. We should have some coverage for regression of fonts that aren't just a LTR and RTL service which are used in a majority of our snapshot testing.

Describe the solution you'd like Implement a form of regression tests that either explicitly check for fonts that should exist for each service. There could also be some form of e2e to detect if a font has loaded on a page correctly? Try and pair with a tester to come up with the best solution.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Testing notes [Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • [ ] This feature is expected to need manual testing.

Checklist

Additional context Add any other context or screenshots about the feature request here.

HarveyPeachey avatar Oct 04 '21 15:10 HarveyPeachey