simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

WSTEAM1-1005: Gujarati Telugu font updates

Open Isabella-Mitchell opened this issue 9 months ago • 1 comments

Resolves JIRA WSTEAM1-1005 - Simorgh Changes, subtask of WSTEAM1-900 - Updated fonts for two Indian services

This has the 'do not merge' label since it depends on other PRs

Overall changes

Updates default fonts for two services Telugu from 'Mallanna' to 'Noto Sans Telugu' Gujarati from 'Mukta Vaani' to 'Noto Sans Gujarati'

Code changes

STORYBOOK

  • Updates Telugu font in storybook
  • Adds Gujarati font to Storybook (I think because the previous one wasn't embedded, I figured it would be useful to add)
  • Adds both in regular and bold

THEME PROVIDER

  • Updates Telugu fontFaces
  • Adds Gujarati fontfaces (I think because the previous one wasn't embedded, I figured it was necessary to add)
  • Adds both in regular and bold (previously Telugu only had regular - figured it would be useful to add bold, but can remove if it's an issue)
  • Update Gujarati and Telugu fontFamilies as per UX comments in the linked subtasks

PSAMMEAD

  • Update legacy by updating psammead font-families.js
  • Update snapshots

Testing

  1. Can preview on Storybook.
  1. Once required font PR is deployed to test, I think we can test this on preview.

Helpful Links

Dropbox paper instructions

Coding Standards

Repository use guidelines

Isabella-Mitchell avatar May 07 '24 13:05 Isabella-Mitchell

Re-running the E2E's on this but Cypress just got patched this morning: https://github.com/bbc/simorgh/pull/11605

And i'm not sure if the failure is related, just FYI.

pvaliani avatar May 09 '24 09:05 pvaliani