simorgh
simorgh copied to clipboard
WSTEAM1-1005: Gujarati Telugu font updates
Resolves JIRA WSTEAM1-1005 - Simorgh Changes, subtask of WSTEAM1-900 - Updated fonts for two Indian services
This has the 'do not merge' label since it depends on other PRs
Overall changes
Updates default fonts for two services Telugu from 'Mallanna' to 'Noto Sans Telugu' Gujarati from 'Mukta Vaani' to 'Noto Sans Gujarati'
Code changes
STORYBOOK
- Updates Telugu font in storybook
- Adds Gujarati font to Storybook (I think because the previous one wasn't embedded, I figured it would be useful to add)
- Adds both in regular and bold
THEME PROVIDER
- Updates Telugu fontFaces
- Adds Gujarati fontfaces (I think because the previous one wasn't embedded, I figured it was necessary to add)
- Adds both in regular and bold (previously Telugu only had regular - figured it would be useful to add bold, but can remove if it's an issue)
- Update Gujarati and Telugu fontFamilies as per UX comments in the linked subtasks
PSAMMEAD
- Update legacy by updating psammead font-families.js
- Update snapshots
Testing
- Can preview on Storybook.
- e.g. message banner on permalink for Telugu vs latest
- e.g. message banner on permalink for Gujarati vs latest
- Once required font PR is deployed to test, I think we can test this on preview.
Helpful Links
Re-running the E2E's on this but Cypress just got patched this morning: https://github.com/bbc/simorgh/pull/11605
And i'm not sure if the failure is related, just FYI.