simorgh
simorgh copied to clipboard
bbc
WSTEAM1-493: POC Bump Media Player
Resolves JIRA WSTEAM1-493
Overall changes
Adds a dynamic Media Player component that loads the correct embedded media player for a user device.
Article Page:
Live Page:
Code changes
-
An EMP loader has been added here
src/app/components/MediaPlayer/index.tsx -
A BUMP settings builder has been added here
/src/app/components/MediaPlayer/utils/buildSettings.ts -
Parameter extractor functions have been modified to fit BUMP requirements here
src/app/legacy/containers/MediaPlayer/helpers/propsInference/default/index.js -
Added the EMP loader to
LivePage
Testing
- For localhost:
-
In your terminal, run
sudo -- sh -c -e "echo '127.0.0.1 localhost.bbc.com' >> /etc/hosts";. -
For the Express app: Go to
http://localhost.bbc.com:7080/afaanoromoo/articles/c4g19kgl85koand check that the video loads. -
For the NextJS app: Go to
http://localhost.bbc.com:7081/pidgin/live/c7p765ynk9qt?renderer_env=testand check that the video loads.
Helpful Links
Add Links to useful resources related to this PR if applicable.
Nice! Just to check my understanding, the BUMP module points to just the standard SMP by default not the Toucan one? And we need the Toucan one for vertical video right ? (dont know much about this planned work)
Nice! Just to check my understanding, the BUMP module points to just the standard SMP by default not the Toucan one? And we need the Toucan one for vertical video right ? (dont know much about this planned work)
Ello, we can request that it returns the Toucan player with adequate ease.
I think the general approach here looks great. Some areas where we could tighten it up when productionising, but the overall implementation is exactly what we're after. Great job!
