simorgh
simorgh copied to clipboard
use new image component in story promo
Partially resolves WSTEAMA-160
Overall change:
Replaces ImageWithPlaceholder
with new Image
component in the StoryPromo
component.
Code changes:
- replaces legacy image component use
- updates the components that use
StoryPromo
to not pass in a custom image component - updates unit/int tests and snapshots
- adds new prop
attribution
inImage
component for the AMP image
Testing notes Requires dev a11y test
- [ ] I have assigned myself to this PR and the corresponding issues
- [ ] I have added the
cross-team
label to this PR if it requires visibility across World Service teams - [ ] I have assigned this PR to the Simorgh project
- [ ] (BBC contributors only) This PR follows the repository use guidelines
Testing:
- [ ] Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- [ ] If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - [ ] This PR requires manual testing