simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

WSTEAM-1 129 Bylines Photo

Open mfonofm opened this issue 1 year ago • 0 comments

Resolves #WSTEAM1-129

Overall change: Adds functionality to include a photo in the byline

Code changes:

  • Add image to byline
  • Add rtl and ltr styles
  • Add bylineWithPhoto fixture data
  • Add byline with image for Storybook
  • Add listItemImage type to translations
  • Add tranlations for 'list item, image'
  • Add unit tests

  • [x] I have assigned myself to this PR and the corresponding issues
  • [ ] I have added the cross-team label to this PR if it requires visibility across World Service teams
  • [ ] I have assigned this PR to the Simorgh project
  • [x] (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • [ ] Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • [ ] If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • [x] This PR requires manual testing

mfonofm avatar Sep 20 '22 19:09 mfonofm