simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

New Subhead Component - Multiple Curations - WSTEAMA-126

Open pvaliani opened this issue 1 year ago • 1 comments

Resolves WSTEAMA-126

Overall change:

  • Creates a new Subhead component

Code changes:

  • This is the first WS TypeScript component for Simorgh
  • Adds ts and tsx extensions to storybook config globs
  • Adds ts and tsx extensions to jest config for unit tests
  • Updates aliased component/hook paths which depend on psammead components to relative paths (temporarily until we refactor when the emotion styling component standards work is complete)
  • Creates new Subhead component with storybook component, unit tests and separate co-located styling file

  • [x] I have assigned myself to this PR and the corresponding issues
  • [ ] I have added the cross-team label to this PR if it requires visibility across World Service teams
  • [ ] I have assigned this PR to the Simorgh project
  • [x] (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • [x] Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • [ ] If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • [ ] This PR requires manual testing

pvaliani avatar Aug 02 '22 10:08 pvaliani

Couple of comments, but looks good, great job! 👍🏼

amoore108 avatar Aug 04 '22 12:08 amoore108