simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

Force cache to miss on topics pages to get fresh data (fixes failing tests)

Open LilyL0u opened this issue 1 year ago • 3 comments

We get a lot of test failures due to a mismatch of the up-to-date data requested from the BFF and the out-of-date cached topics page. Adding the random query string to the end forces to cache to be missed and the page always has fresh data. This is done with the uuid package for generating a random ID.


  • [x] I have assigned myself to this PR and the corresponding issues
  • [x] I have added the cross-team label to this PR if it requires visibility across World Service teams
  • [x] I have assigned this PR to the Simorgh project
  • [x] (BBC contributors only) This PR follows the repository use guidelines

Testing:

Passes on test and live

LilyL0u avatar Jul 26 '22 12:07 LilyL0u

looks good but I think that when you merged latest, you accidentally brought in a load of files that should be there

Do I need to do anything about this?

LilyL0u avatar Jul 26 '22 14:07 LilyL0u

'error: gpg failed to sign the data' :( can't push changes

LilyL0u avatar Jul 26 '22 15:07 LilyL0u

error: gpg failed to sign the data

😭 that generally is an issue on your local machine rather than anything happening on the repo

if you haven't changed anything in your local setup, your key has probably expired - this link might help: https://inspirezone.tech/using-gpg-keys-on-github/ or can jump on a zoom call tomorrow!

RetiredBlob avatar Jul 26 '22 15:07 RetiredBlob