react-transcript-editor icon indicating copy to clipboard operation
react-transcript-editor copied to clipboard

Published 20 hours ago • verified publisher icon bbc

Fix for issue #247 "unexpected scroll behavior"

Open shea12 opened this issue 4 years ago • 1 comments

Is your Pull Request request related to another issue in this repository ?
Yes, issue #247

Describe what the PR does
This PR removes a call to setState inside the time text editor component's updateTimestampsForEditorState method because it causes the scroll bug in the issue linked above. In testing, we did not find any adverse effects of removing the call to setState.

State whether the PR is ready for review or whether it needs extra work
Ready!

Additional context Below is a screen recording of the fix to compare with the screen recording of the bug in the issue linked above. react-transcript-editor-fix

shea12 avatar Oct 23 '20 19:10 shea12

Thanks @shea12 for the PR :)

emettely avatar Oct 29 '20 10:10 emettely